Skip to content

Shipping Labels: Mark manually saved addresses as unverified #16013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 20, 2025
Merged

Shipping Labels: Mark manually saved addresses as unverified #16013

merged 5 commits into from
Aug 20, 2025

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Aug 15, 2025 •
edited
Loading

Closes WOOMOB-980

Description

This PR updates the verification state for manually saved addresses as unverified. Specifically:

  • Updates the Networking and Yosemite layers to accept isVerified boolean for the update destination address endpoint.
  • Updates the UI layer to send isVerified as false if the saved destination addressed cannot be validated.
  • Updates the shipment detail bottom sheet to display the correct verification status of destination address.

Testing steps

  1. Log in to a test store with Woo Shipping set up.
  2. Start shipping label creation for an order.
  3. Edit the destination address to be invalid and save it regardless.
  4. Confirm that the addressed is saved as unverified on the shipment details bottom sheet.
  5. Exit and enter the shipping label creation form of the same order.
  6. Confirm that the verification status of the destination address is still unverified.

Testing information

Tested and verified with simulator iPhone 16 iOS 18.2.

Screenshots

Simulator.Screen.Recording.-.iPhone.16.-.2025-08-15.at.14.49.53.mp4
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.1 milestone Aug 15, 2025
@itsmeichigo itsmeichigo added feature: shipping labels Related to creating, ordering, or printing shipping labels. Bug labels Aug 15, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Aug 15, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16013-3e929e5
Version23.0
Bundle IDcom.automattic.alpha.woocommerce
Commit3e929e5
Installation URL6g3nfnbdalbd8
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review August 18, 2025 10:11
Base automatically changed from woomob-982-remove-the-button-print-shipping-label-from-the-shipping to trunk August 19, 2025 01:58
@hichamboushaba hichamboushaba self-assigned this Aug 19, 2025
hichamboushaba
hichamboushaba approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, nice work @itsmeichigo

@itsmeichigo itsmeichigo enabled auto-merge August 20, 2025 02:20
@itsmeichigo itsmeichigo merged commit 732cda3 into trunk Aug 20, 2025
14 checks passed
@itsmeichigo itsmeichigo deleted the woomob-980-mark-manually-saved-addresses-as-unverified branch August 20, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hichamboushaba hichamboushaba hichamboushaba approved these changes

Assignees

@hichamboushaba hichamboushaba

Labels

Bug feature: shipping labels Related to creating, ordering, or printing shipping labels.

Projects

None yet

Milestone

23.1

Development

Successfully merging this pull request may close these issues.

4 participants

@itsmeichigo @wpmobilebot @hichamboushaba